Skip to content

Definition of Done

Every subtask must satisfy six criteria before /review can issue a Pass verdict. The verdict comment checks against this list.

  • All AC are satisfied.
  • Tests exist (when applicable).
  • PR body contains the Issue number (Closes #N / Fixes #N / Resolves #N).
  • Zero lint errors.
  • Code review pipeline executed and findings addressed (per the code review process).
  • Review has passed.

Each item has a precise rule:

  • “Tests exist” applies to business logic, API endpoints, and utility functions — not to configuration changes with no logic.
  • “Issue number” specifically requires one of the GitHub-recognised auto-close keywords.

Two moments:

  • During /develop, the developer agent self-checks every item except “Review has passed” — the developer cannot self-grant the review verdict.
  • During /review, all six items are verified, including the review pass /review is about to issue. The verdict comment lists per-item OK / Not OK with rationale.

Repositories can add DoD requirements in .claude/rules/dod-extra.md. Entries are appended to the core list, not replaced.