Definition of Done
Every subtask must satisfy six criteria before /review can issue a Pass verdict. The verdict comment checks against this list.
The checklist
Section titled “The checklist”- All AC are satisfied.
- Tests exist (when applicable).
- PR body contains the Issue number (
Closes #N/Fixes #N/Resolves #N). - Zero lint errors.
- Code review pipeline executed and findings addressed (per the code review process).
- Review has passed.
Each item has a precise rule:
- “Tests exist” applies to business logic, API endpoints, and utility functions — not to configuration changes with no logic.
- “Issue number” specifically requires one of the GitHub-recognised auto-close keywords.
When this applies
Section titled “When this applies”Two moments:
- During
/develop, the developer agent self-checks every item except “Review has passed” — the developer cannot self-grant the review verdict. - During
/review, all six items are verified, including the review pass/reviewis about to issue. The verdict comment lists per-item OK / Not OK with rationale.
Repo-specific extras
Section titled “Repo-specific extras”Repositories can add DoD requirements in .claude/rules/dod-extra.md. Entries are appended to the core list, not replaced.
See also
Section titled “See also”- Why the auto-close keyword matters: PR lifecycle.
- Canonical contract:
skills/soloscrum-define-dod/SKILL.md.